[Konsole-devel] Review Request: split view: automatically close the split area if it becomes empty.

[Kurt Hindenburg]

> On Nov. 11, 2012, 4:04 p.m., Kurt Hindenburg wrote:
> > On initial testing, it looks good so far.  Once master is unlocked for 4.11, we'll see about putting it in for more testing.  Thanks.

I'm getting crashes on the dnd tab to the other window - has anyone else tested this lately?


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104717/#review21828
-----------------------------------------------------------


On Nov. 11, 2012, 11:32 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104717/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 11:32 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> automatically close blank split, after that last tab is moved.
> 
> 
> This addresses bug 275771.
>     http://bugs.kde.org/show_bug.cgi?id=275771
> 
> 
> Diffs
> -----
> 
>   src/ViewContainer.h d5bdf73 
>   src/ViewContainer.cpp d6d17a9 
>   src/ViewContainerTabBar.h 5b97abc 
>   src/ViewContainerTabBar.cpp c3a9dd1 
>   src/ViewManager.h 7d1079e 
>   src/ViewManager.cpp faa1395 
> 
> Diff: http://git.reviewboard.kde.org/r/104717/diff/
> 
> 
> Testing
> -------
> 
> - one tab + split + one tab -> move split right/left, no blank area
> - from bug: after step 4 no blank area
> 
> seems to work well but more test are necessary. ;)
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130110/c83191ff/attachment.html>