[Konsole-devel] Review Request 109130: Make search strings per-tab, not per-window

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109130/#review28043
-----------------------------------------------------------


Yes I agree - a quick glance and it works - thanks - I'll test it some more and commit

- Kurt Hindenburg


On Feb. 24, 2013, 8:35 p.m., Lindsay Roberts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109130/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 8:35 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Currently the presence of the search bar is maintained per-tab, but the search
> term itself is per-window. This leads to curiously inconsistent behaviour.
> I believe there is little to suggest search terms remain relevant across
> different tabs, and there is significant user expectation that search terms
> (and the presence of the bar itself) are constrained to a tab (see browsers).
> 
> 
> Diffs
> -----
> 
>   src/IncrementalSearchBar.h e8153d6 
>   src/IncrementalSearchBar.cpp c8c5b0c 
>   src/SessionController.h 390cc01 
>   src/SessionController.cpp d310a50 
> 
> Diff: http://git.reviewboard.kde.org/r/109130/diff/
> 
> 
> Testing
> -------
> 
> Loads of tab-switchin' and searchin'.
> 
> 
> Thanks,
> 
> Lindsay Roberts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130225/cbae5cdd/attachment.html>