[Konsole-devel] Review Request 109042: Add command line option to enter fullscreen mode

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109042/#review27808
-----------------------------------------------------------

Ship it!


The patch looks fine to me.

I also prefer to keep the semantic of this new cmdline option minimal and consistent with the "Full Screen Mode" action.

- Jekyll Wu


On Feb. 19, 2013, 2:51 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109042/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 2:51 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This allow for --fullscreen on the command line
> 
> I'm not sure if users would expect fullscreen to automatically hide tabbar and menubar.  They can add those command line options if they want currently.
> 
> 
> This addresses bug 312378.
>     http://bugs.kde.org/show_bug.cgi?id=312378
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp fb7e09d 
>   src/MainWindow.h d81dbe5 
>   src/main.cpp f779b15 
> 
> Diff: http://git.reviewboard.kde.org/r/109042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130221/20b6456b/attachment.html>