[Konsole-devel] Review Request 107640: Prevent the opening of two or more "edit profile dialogs" per session.

[Francesco Cecconi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107640/
-----------------------------------------------------------

(Updated Feb. 20, 2013, 3:55 p.m.)


Review request for Konsole.


Changes
-------

fix for Manage profile dialog.


Description
-------

Looking at the code, the best solution for the issue described in the bug is:

Fixing the wrong behaviour to open two or more "edit dialog" for one session/tab with 
the same profile (it should be fixed anyway and this is the issue of the bug 311270 ), 
and the crash with two or more "edit dialog", one for different session(tabs)
with the same profile.

With the patch:
one tab/session -> only one edit profile dialog at the same time ( 311270 )

tab1/session -> edit profile (profile1)
tab2/session -> edit profile (profile1)  
...
tab[i]/session -> edit profile (profile1)

many tab with the same profile, only one edit dialog is shown

NOTE:The issue(crash) appears only when transparency property is modified by one of the two profiles.


This addresses bug 311270.
    http://bugs.kde.org/show_bug.cgi?id=311270


Diffs (updated)
-----

  src/EditProfileDialog.h 30d72e5 
  src/ManageProfilesDialog.cpp 3b270dc 
  src/SessionController.h 390cc01 
  src/SessionController.cpp 0691856 
  src/TerminalDisplay.h 1747f1b 
  src/TerminalDisplay.cpp 6a206c5 

Diff: http://git.reviewboard.kde.org/r/107640/diff/


Testing
-------


Thanks,

Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130220/06e78935/attachment.html>