[Konsole-devel] Review Request 108998: Search toward most recent lines by default

[Francesco Cecconi]

> On Feb. 19, 2013, 3:19 p.m., Kurt Hindenburg wrote:
> > Interesting idea - gnome-terminal does this however this is due to their having a 'search backwards' option that is enable by default.
> > 
> > I think in my use cases I would prefer applying this patch.   Any one else have an opinion?

+1 - I'm agree with this change.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108998/#review27727
-----------------------------------------------------------


On Feb. 17, 2013, 6:41 p.m., Lindsay Roberts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108998/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 6:41 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is a fairly simple diff mechanically, but does change noticeable behaviour.
> 
> Current history search searches "down", wrapping instantly from the current
> location to search from oldest to newest. As lines in a terminal generally
> decrease in relevance as they move away from current output, the most
> relevant lines and therefore search results can be found "upwards" of the
> current output line. This patch makes searches default to "up".
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 0691856 
> 
> Diff: http://git.reviewboard.kde.org/r/108998/diff/
> 
> 
> Testing
> -------
> 
> Tested with several search invocation methods and for a variety of use cases involving log tailing and output highlighting.
> 
> 
> Thanks,
> 
> Lindsay Roberts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130220/cb77a2d7/attachment.html>