[Konsole-devel] Review Request 108998: Search toward most recent lines by default

Lindsay Roberts linds.r at gmail.com
Sun Feb 17 18:41:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108998/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

This is a fairly simple diff mechanically, but does change noticeable behaviour.

Current history search searches "down", wrapping instantly from the current
location to search from oldest to newest. As lines in a terminal generally
decrease in relevance as they move away from current output, the most
relevant lines and therefore search results can be found "upwards" of the
current output line. This patch makes searches default to "up".


Diffs
-----

  src/SessionController.cpp 0691856 

Diff: http://git.reviewboard.kde.org/r/108998/diff/


Testing
-------

Tested with several search invocation methods and for a variety of use cases involving log tailing and output highlighting.


Thanks,

Lindsay Roberts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130217/42413df0/attachment.html>


More information about the konsole-devel mailing list