[Konsole-devel] Review Request 107640: Prevent the opening of two or more "edit profile dialogs" per session.

[Francesco Cecconi]

> On Feb. 10, 2013, 5:08 p.m., Kurt Hindenburg wrote:
> > I get crashing when there are multiple windows and try to edit profile dialog - can you see if you can reproduce?  
> > 
> > 0   libkonsoleprivate.dylib       	0x000000010214bf26 Konsole::ColorScheme::foregroundColor() const + 22 (qcolor.h:293)
> > 1   libkonsoleprivate.dylib       	0x000000010215e7cf Konsole::ColorSchemeViewDelegate::paint(QPainter*, QStyleOptionViewItem const&, QModelIndex const&) const + 367 (EditProfileDialog.cpp:1273)

Hmm, yes I can reproduce the crash but the new patch should fix the issue.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107640/#review27133
-----------------------------------------------------------


On Jan. 13, 2013, 12:03 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107640/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 12:03 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Looking at the code, the best solution for the issue described in the bug is:
> 
> Fixing the wrong behaviour to open two or more "edit dialog" for one session/tab with 
> the same profile (it should be fixed anyway and this is the issue of the bug 311270 ), 
> and the crash with two or more "edit dialog", one for different session(tabs)
> with the same profile.
> 
> With the patch:
> one tab/session -> only one edit profile dialog at the same time ( 311270 )
> 
> tab1/session -> edit profile (profile1)
> tab2/session -> edit profile (profile1)  
> ...
> tab[i]/session -> edit profile (profile1)
> 
> many tab with the same profile, only one edit dialog is shown
> 
> NOTE:The issue(crash) appears only when transparency property is modified by one of the two profiles.
> 
> 
> This addresses bug 311270.
>     http://bugs.kde.org/show_bug.cgi?id=311270
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h c85bd11 
>   src/SessionController.h aefdbc6 
>   src/SessionController.cpp fd58ecc 
> 
> Diff: http://git.reviewboard.kde.org/r/107640/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130210/ed018f28/attachment.html>