[Konsole-devel] Review Request 107427: update konsole_wcwidth.cpp/h files.

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Feb 9 18:52:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107427/#review27094
-----------------------------------------------------------

Ship it!


Thanks it looks good now - using kdiff3 really helps w/ these complex diffs

- Kurt Hindenburg


On Feb. 9, 2013, 5:54 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107427/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 5:54 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> update konsole_wcwidth.cpp/h files.
> 
> References:
> 
> - http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c
> - wcwidth.* xterm files
> 
> 
> Diffs
> -----
> 
>   src/konsole_wcwidth.h 7bc863f 
>   src/konsole_wcwidth.cpp a2a3309 
> 
> Diff: http://git.reviewboard.kde.org/r/107427/diff/
> 
> 
> Testing
> -------
> 
> - test/UTF-8-demo.txt
> - http://www.cl.cam.ac.uk/~mgk25/ucs/examples/ 
>   + UTF-8-demo.txt
>   + UTF-8-test.txt
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130209/e54d1b2d/attachment.html>


More information about the konsole-devel mailing list