[Konsole-devel] Review Request 105325: protect control characters from deletion

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105325/#review27089
-----------------------------------------------------------


In general these look like a place to start but they need a lot more work.  The whole way Konsole handles spaces/non-visible spaces is a mess.

- Kurt Hindenburg


On June 25, 2012, 12:40 p.m., Alexander Sulfrian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105325/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 12:40 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This review contains three patches. I do not know how to submit them as separate
> patches for one review. I attached the single patches as files to the review.
> 
> - protect control characters from deletion
> 
>   If you remove characters from a line (replace with space) and first
>   character, that should be removed, is the first character with a new
>   color, do not remove the color but replace the character.
> 
> - save color on change
> 
>   If the colors change, you need to save it in the next character to be
>   able to complete the line with the correct colors.
> 
> - keep color for additional character at line end
> 
>   If the current line contains less characters than the width of the
>   current window, default chars were used to draw the additional
>   characters. This results in transparent (missing) line endings in some
>   ncurses applications, that draw lines using the background of space
>   characters. This keeps the color of the last character to draw the
>   missing chars.
> 
> 
> This addresses bug 278991.
>     http://bugs.kde.org/show_bug.cgi?id=278991
> 
> 
> Diffs
> -----
> 
>   src/Character.h cd4e230 
>   src/Screen.cpp cc29cf6 
> 
> Diff: http://git.reviewboard.kde.org/r/105325/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> keep color for additional character at line end
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/06/25/0001-keep-color-for-additional-character-at-line-end.patch
> save color on change
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/06/25/0002-save-color-on-change.patch
> protect control characters from deletion
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/06/25/0003-protect-control-characters-from-deletion.patch
> 
> 
> Thanks,
> 
> Alexander Sulfrian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130209/69536400/attachment.html>