[Konsole-devel] Review Request 107427: update konsole_wcwidth.cpp/h files.

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107427/#review27070
-----------------------------------------------------------



src/konsole_wcwidth.cpp
<http://git.reviewboard.kde.org/r/107427/#comment20385>

    Instead of all this variable changing ucs->cmp I would prefer changing the method variable above.
    Something like:
    int konsole_wcwidth(quint16 oucs) and then use ucs = the static cast
    


Let me know if you have time to work on this - if not I can try to get something together for 4.11

- Kurt Hindenburg


On Nov. 23, 2012, 1:05 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107427/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 1:05 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> update konsole_wcwidth.cpp/h files.
> 
> References:
> 
> - http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c
> - wcwidth.* xterm files
> 
> 
> Diffs
> -----
> 
>   src/konsole_wcwidth.cpp a2a3309 
>   src/konsole_wcwidth.h 7bc863f 
> 
> Diff: http://git.reviewboard.kde.org/r/107427/diff/
> 
> 
> Testing
> -------
> 
> - test/UTF-8-demo.txt
> - http://www.cl.cam.ac.uk/~mgk25/ucs/examples/ 
>   + UTF-8-demo.txt
>   + UTF-8-test.txt
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130209/ec9713ef/attachment.html>