[Konsole-devel] Review Request 108844: Add support for ANSI SGR escape code 3 (italics) to Konsole

[Jem Orgun]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108844/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

Adds support for escape sequences \e[3m and \e[23m (to turn italics on and off respectively). I have no idea if this is actually a standard, but it's listed on Wikipedia, (http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes), implemented in urxvt, and used by vim, so evidently it has some grounding.
This is my first time doing this, so if I'm doing something wrong please tell me.


Diffs
-----

  src/Character.h ced1621 
  src/TerminalDisplay.cpp d14daba 
  src/Vt102Emulation.cpp 1ab7758 

Diff: http://git.reviewboard.kde.org/r/108844/diff/


Testing
-------

` echo -e "\e[1mbold\e[22m \e[3mitalic\e[23m \e[4munderline\e[24m \e[5mblink\e[25m \e[7mreverse\e[27m" ' works as expected.


Thanks,

Jem Orgun

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130208/07009b63/attachment.html>