[Konsole-devel] Review Request 104605: Change the "Bold" key of ColorScheme from boolean to tri-state

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104605/#review26900
-----------------------------------------------------------


I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert Astals Cid


On April 15, 2012, 11:35 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104605/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 11:35 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Tha patch is trivial. Konsole now supports "Bold=true", "Bold=false" and other values(which all mean using Character::UseCurrentFormat).
> 
> However, I just wonder how useful this per-color boldness controlling could be. We already have the "BoldIntense" per-profile option to enable or disable boldness. Do we need two levels of boldness control: per-profile and per-color in each colorscheme?
> 
> 
> This addresses bug 168300.
>     http://bugs.kde.org/show_bug.cgi?id=168300
> 
> 
> Diffs
> -----
> 
>   src/ColorScheme.cpp 1acb4d4 
> 
> Diff: http://git.reviewboard.kde.org/r/104605/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130207/f37ba5a1/attachment.html>