[Konsole-devel] Review Request 114376: Implement a file filter in Konsole that uses POSIX portable filename character set along with KDE mimetype database file extension blobs

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114376/#review45633
-----------------------------------------------------------


Just one minor nitpick, otherwise it looks okay to me. But should probably get a final ship it from hindenburg.


src/Filter.h
<http://git.reviewboard.kde.org/r/114376/#comment32592>

    Is this still needed?


- Martin Tobias Holmedahl Sandsmark


On Dec. 10, 2013, 2:13 a.m., Adam Treat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114376/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 2:13 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Implement a new file filter using POSIX Portable Filename Character Set
> along with KDE's mimetype database of file extension blobs that filters
> text matching a POSIX portable pathname and underlines it very much like
> links.
>     
> Info on the character set allowed can be found at this link:
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_267
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.ui 82298cf 
>   src/Filter.h cbcc8e2 
>   src/Filter.cpp 5818054 
>   src/SessionController.h 2ff7910 
>   src/SessionController.cpp 62c1d0b 
> 
> Diff: http://git.reviewboard.kde.org/r/114376/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local system with a chromium code base and displaying all the local files therein and displaying in konsole and opening via filter in kate.
> 
> 
> Thanks,
> 
> Adam Treat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20131213/43187d1b/attachment.html>