[Konsole-devel] Review Request 111937: Port to KF5/Qt5

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111937/#review37737
-----------------------------------------------------------


Still ok from the buildsystem pov. Let's wait for the maintainer 'ship it' in case he changes his mind (again).



CMakeLists.txt
<http://git.reviewboard.kde.org/r/111937/#comment27930>

    Now you can move it below find_package(ECM) :-)
    
    ECM requires a recent CMake version. When including FeatureSummary just after looking for ECM ensures, you're certain that CMake provides this file.
    


- Christophe Giboudeaux


On Aug. 13, 2013, 9:56 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111937/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 9:56 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Port to KF5/Qt5
> 
> TerminalDisplayAccessible is disabled for Qt5 currently since I don't
> have any experience with accessible stuff and it is more complicated
> than just changing a few includes
> 
> REVIEW: 111937
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5783804588bc4b1d1687e2dd1aaff76f3a65906e 
>   src/BookmarkHandler.h 76c33269e5f20cbe20c97cfa621236cf05dc0f53 
>   src/BookmarkHandler.cpp 9fc1600aa5a2901549f87295894acaf88b2f55ed 
>   src/CMakeLists.txt 48601a147b4ba9a48eee064d9071382d6dd683b1 
>   src/ColorScheme.cpp 6945c39144d12d8faefbb5242edfa1899e278477 
>   src/ColorSchemeEditor.cpp afe13c3a447197ff864639be3d6c136b146c8c66 
>   src/ColorSchemeManager.cpp 802f5d7f9d3a1008a8785b27546a7ffa27fac24c 
>   src/EditProfileDialog.cpp cf7be3d72ec83ae4a9b34cea80d3e444c0c36592 
>   src/Emulation.cpp 02ed4be48a5916c75c7731864b33b4a825c31e6e 
>   src/Filter.cpp 8f40c0c598bd1f61ec2ad9765c2399d0ba011744 
>   src/KeyBindingEditor.cpp 005b9e32027dd14f9965ec6e2e7dd32e94b79272 
>   src/KeyboardTranslator.h 99c71743d6c295c14381a83787baa061e7703878 
>   src/KeyboardTranslator.cpp 8fe2acb40d75b62595b9823a990ba99f0e6e0509 
>   src/KeyboardTranslatorManager.cpp 4d46210517e901b14e379dcfe435fd8fdedaeb09 
>   src/MainWindow.h b297883eb9d62215ac71564b77c2145c1c8eeacc 
>   src/MainWindow.cpp 285d6347be6680632b912b51961ced4d797a10bc 
>   src/Part.h 2806bcdb066814ca32e1905772e99a0b2de426e5 
>   src/Part.cpp 33e2d3849629e415817dc9a5f241e4ac3a323a28 
>   src/PrintOptions.cpp 5e802987d5872f9041438a1ee69ec8162ddb962a 
>   src/Profile.cpp 14946ce69000eef00b03864e4610c6775597a51d 
>   src/SessionController.h 036e0534960fe7a1bd32be04136ba162c0469413 
>   src/SessionController.cpp 88fc50c6a164fed94eefc72a71e4460f15ede57e 
>   src/ShellCommand.cpp 2b059a16e6232146cc9d75b1b6af25919fdcc4e7 
>   src/TerminalDisplay.cpp acfddc176bc68ae9b0f3a9ea52c958e37d14dff8 
>   src/TerminalDisplayAccessible.h c6964412559e880dd27cf66a9fa8759196a09980 
>   src/TerminalDisplayAccessible.cpp 8d37dc5e13448fc5d8619078c50334b0813597d4 
>   src/ViewManager.cpp 4b9708e4a135a3682b319351ba02ce1d310c3329 
>   src/Vt102Emulation.cpp 0b6d2ed2f75630df9fc7ac5d6d2b5d9a6702f254 
>   src/main.cpp 2afc62c721b0e77264d0784caf7fbbd70b13951f 
>   src/tests/DBusTest.cpp 729df8bf3dcb9bfed1aa62b40ca5d2ea08a40581 
>   src/tests/PartTest.cpp 72cd27de07c0e96f8986db3a40dcf9239d9b3529 
>   src/tests/ShellCommandTest.cpp d03964fda57a1b37d4a02c82c3c04fd00040aaff 
> 
> Diff: http://git.reviewboard.kde.org/r/111937/diff/
> 
> 
> Testing
> -------
> 
> It compiles fine (both Qt4 and Qt5).
> After installation the terminal view of KF5 based okteta started working.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130813/ef7401e0/attachment.html>