[Konsole-devel] Review Request 111766: Incremental search bar improvements

[Harald Hvaal]

> On Aug. 4, 2013, 7:22 p.m., Kurt Hindenburg wrote:
> > A few things I've noticed testing this
> > 
> > 1. Search no longer loops back around top->bottom - Search backwards is not checked - clicking 'previous' will not loop to the bottom of the non-visible screen.
> > 2. Search from beginning is a little confusing - it is not apparent what 'beginning' refers to.
> > 3. When looping around top-> bottom or bottom->top, there seems to require an extra click on the next/prev to get the search to find the next match

Drat, I just noticed that I never posted my reply a week ago because I had to push Publish after clicking OK on the comment. But I'll post the old reply first, and write a new reply for the fixes I have done since then.

--- the one week old reply ---


1. are you sure you're not searching for a word on the first line? I've noticed that wrapping doesn't work when the hit is on line 0, but this was not introduced by this patch.
2. it was originally named "search from top", but the reverse search option complicated things
3. yeah, this needs fixing

all in all there are a few things that still need fixing, but now that I know I caught your attention, I will be sure to fix them.
as a sidenote, I've been using konsole with these modifications at work for a week, and while I enjoy the bugfix, I have noticed the automatically-search-for-selected-text feature is a bit intrusive - I'm thinking it would be better to just set the search text when text is selected, and the search hotkey is subsequently triggered.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111766/#review37073
-----------------------------------------------------------


On July 29, 2013, 10:19 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111766/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 10:19 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> commit 4f3ac690828c4d7a707ddae38d977798a6e2c13d
> Author: Harald Hvaal <harald.hvaal at gmail.com>
> Date:   Sun Jul 28 11:24:37 2013
> 
>     Various search-related improvements
>     
>     - Add "search from beginning" feature
>         This will scroll to the top and search from there.
>         Ctrl+return is also bound to this action
>     - Text Highlighted by mouse will be set as the current search text
>     - Add "Search backwards" to search bar options
> 
> commit 36e59043ba41b4ea9fd31bd961b0b88e20da10e1
> Author: Harald Hvaal <harald.hvaal at gmail.com>
> Date:   Sat Jul 27 10:07:21 2013
> 
>     When showing the search bar, do not invoke a search, only apply the highlight filters
> 
> commit fb2202fd4f54d0e1a82a861d0d998582cc08780c
> Author: Harald Hvaal <harald.hvaal at gmail.com>
> Date:   Sat Jul 27 19:51:32 2013
> 
>     Scroll with the result centered
> 
> commit 7b8f805fd15e18bb6cdba520292dd7afb0f7e4e3
> Author: Harald Hvaal <harald.hvaal at gmail.com>
> Date:   Sat Jul 27 09:39:27 2013
> 
>     Do not automatically reset the search start line on search hits
>     
>     This was causing the annoying behavior that if you were to pause while typing
>     in a search term, and it would actually find a hit, then you would be searching
>     for the term a second time once you finish typing.
>     
>     Example console output:
>     
>      ***
>     1 usb
>     2 hdmi
>     3 usb
>     4 hdmi
>     5 usb
>      ***
>     
>     if you were to search for this by quickly typing "usb" you would get the hit on
>     line 1.  If you type "us", wait a moment, then type "b", you will end up on
>     line 3. When searching through large console output, this is frustrating as you
>     would never really be sure whether you are at the first search result without
>     double-checking.
>     
>     This commit introduces two new behaviors:
>     1. When you show the search bar, all searching will be done from the first
>         visible line in the terminal.
>     2. This start position is only reset when you
>         advance to the next result, by pressing "next", "previous", or the shortcuts
>         RETURN or SHIFT-RETURN
>     
>     In the example above, this would ensure that you would end up at the hit on
>     line 1 as expected.
> 
> 
> Diffs
> -----
> 
>   src/IncrementalSearchBar.h d0661a5ae539fe6e11800e2367d6a55660b3028b 
>   src/IncrementalSearchBar.cpp 79a28773c64513ccc95375eef9a51b0e13b81a9f 
>   src/SessionController.h 036e0534960fe7a1bd32be04136ba162c0469413 
>   src/SessionController.cpp 88fc50c6a164fed94eefc72a71e4460f15ede57e 
>   src/TerminalDisplay.cpp acfddc176bc68ae9b0f3a9ea52c958e37d14dff8 
> 
> Diff: http://git.reviewboard.kde.org/r/111766/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130811/e9984306/attachment.html>