[Konsole-devel] Review Request 109891: Add customizable display's contents margins

Mariusz Glebocki mglb at arccos-1.net
Sun Apr 7 05:45:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109891/
-----------------------------------------------------------

(Updated April 7, 2013, 7:45 a.m.)


Review request for Konsole.


Description
-------

Add customizable display's contents margins
    
Minor changes include possibility of centering the contents on the display, cleaner terminal's contents size and position related code (without magic numbers), better handling of a mouse over effect on links.


Diffs
-----

  src/EditProfileDialog.h 30d72e5 
  src/EditProfileDialog.cpp 74b0237 
  src/EditProfileDialog.ui 592370a 
  src/Profile.h fea0d73 
  src/Profile.cpp 4995d90 
  src/TerminalDisplay.h 1747f1b 
  src/TerminalDisplay.cpp d14daba 
  src/ViewManager.cpp 4071b8b 

Diff: http://git.reviewboard.kde.org/r/109891/diff/


Testing
-------

Changing each margin size and toggling the contents centering option, then:
* resizing the window
* moving/hiding/scrolling the scrollbar
* selecting a text
* moving the cursor over links


Thanks,

Mariusz Glebocki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130407/bae1009d/attachment.html>


More information about the konsole-devel mailing list