[Konsole-devel] Review Request: remove duplicated entry “Show Menu Bar” from KShortcutsDialog.

[Kurt Hindenburg]

> On Sept. 22, 2012, 6:06 p.m., Kurt Hindenburg wrote:
> > This does seem to work - I would still think that the .rc files could be tweaked to avoid the duplicate but I can't quite figure it out.   Since this code is only called upon opening the shortcut menu, I guess it is OK.
> > Jekyll?

Actually review 104193 might be a better approach - let me look at it more.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106055/#review19313
-----------------------------------------------------------


On Aug. 26, 2012, 3:55 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106055/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 3:55 p.m.)
> 
> 
> Review request for Konsole, Jekyll Wu and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> remove duplicated entry “Show Menu Bar” when showing the shortcut dialog.
> 
> ref. Jekyll Wu review request: #104193
> 
> 
> This addresses bug 214493.
>     http://bugs.kde.org/show_bug.cgi?id=214493
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp fe2700c 
> 
> Diff: http://git.reviewboard.kde.org/r/106055/diff/
> 
> 
> Testing
> -------
> 
> seems fine on stand-alone konsole.
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120922/610b6362/attachment.html>