[Konsole-devel] Review Request: Fix for 'Search for...' filter support in Konsole

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106419/#review18848
-----------------------------------------------------------

Ship it!


Ship It!

- Kurt Hindenburg


On Sept. 10, 2012, 2:13 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106419/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2012, 2:13 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This one liner patch fixes, the 'Search for...' filter support in Konsole. The KRun ctor should not be called with its "isLocalFile" set to true when you are trying to open a remote URL. The fix changes the KRun call to be the same as the one used when options like 'Open Link' are activated.
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 4d14926 
> 
> Diff: http://git.reviewboard.kde.org/r/106419/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120911/e5fa5c75/attachment.html>