[Konsole-devel] [Bug 306567] New: Tab title set manually is lost when connecting to remote

[Michel Palleau]

https://bugs.kde.org/show_bug.cgi?id=306567

            Bug ID: 306567
          Severity: minor
           Version: 2.9.999
          Priority: NOR
          Assignee: konsole-devel at kde.org
           Summary: Tab title set manually is lost when connecting to
                    remote
    Classification: Unclassified
                OS: Linux
          Reporter: michel.palleau at gmail.com
          Hardware: Compiled Sources
            Status: UNCONFIRMED
         Component: tabbar
           Product: konsole

Created attachment 73798
  --> https://bugs.kde.org/attachment.cgi?id=73798&action=edit
Proposal to set both titles on manual setting

When setting manually the tab title with "\e]30;TITLE\a", it only updates the
local tab name, not the remote tab name.
So, if connecting to a remote server, "\e]30;TITLE\a" shows the title during
half a second before konsole restores the remote tab name.
I have checked the code, and behavior via the dbus setTitle command and via
\e]30; command is not consistent.
I propose to make the following change to have the same behavior, id est update
both local and remote tab name on any manual setting (be it dbus or character
control).

diff --git a/src/Session.cpp b/src/Session.cpp
index dfb0ab7..11c3f4f 100644
--- a/src/Session.cpp
+++ b/src/Session.cpp
@@ -534,7 +534,7 @@ void Session::setUserTitle(int what, const QString&
caption)
     if (what == SessionName) {
         if (_localTabTitleFormat != caption) {
             _localTabTitleFormat = caption;
-            setTitle(Session::DisplayedTitleRole, caption);
+            setTitle(static_cast<int>(Session::DisplayedTitleRole), caption);
             modified = true;
         }
     }

-- 
You are receiving this mail because:
You are the assignee for the bug.