[Konsole-devel] Review Request: Add process info gathering support on OpenBSD

[Vadim Zhukov]

> On Oct. 17, 2012, 8:24 p.m., Jekyll Wu wrote:
> > Thanks for the update. Looks fine to me, although I really want to try the patch in a real environment before applying it. Basically I just followed the instruction from the openbsd-kde google group, but unfortunately it did not work that time. I will try it again sometime later.
> > 
> > Anyway, the patch in its current form won't bring any danger to users on other platforms,  so I will push it so that more 
> > OpenBSD users have a chance of trying it. And if it goes wrong badly, OpenBSD packagers can disable this feature by commenting off just two lines as temporary workaround.  
> > 
> > Be prepared for bug reports. I might just redirect related bug reports to you :)
> >

Don't worry, those reports will be more likely directed to me initially 'cause I'm one of the KDE-on-OpenBSD packagers you mentioned. :) And a few people already tested it on i386 and amd64 platforms.

Our project isn't "official" KDE porting project yet; I want to get 4.9.2 fully available, resulting in potentially wider test audience. And only then push all the patches we have upstream. Current patch is just one of the biggest and thus annoying ones, so I published it earlier. :)


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/#review20523
-----------------------------------------------------------


On Oct. 4, 2012, 10:50 a.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106129/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 10:50 a.m.)
> 
> 
> Review request for Konsole and Jekyll Wu.
> 
> 
> Description
> -------
> 
> ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support.
> The first idea was to extend already existing FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. After some input I've created separate OpenBSDProcessInfo class based on FreeBSDProcessInfo code.
> 
> I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() and such; added kWarning() printouts if they fail) in new code. If needed I can do them as a separate diff.
> 
> 
> Diffs
> -----
> 
>   src/ProcessInfo.cpp 32c86b1 
> 
> Diff: http://git.reviewboard.kde.org/r/106129/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121017/04075bd8/attachment.html>