[Konsole-devel] Review Request: After a search, when an user click left button on the konsole view, disable all search filter.

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106720/#review20011
-----------------------------------------------------------


Well, I tend to differ from your opinion.

First, kate/kwrite/kdevelop are actually just about katepart. If you take some other KDE applications(rekonq, okular, calligra words, etc) into account, konsole is consistent with them. Another important difference between konsole and katepart is konsole highlight all matches and  katepart seems to only highlight the current match.


Second, I can think of at least one use case where the suggested behavior would be really annoying, based upon my daily usage.

Use case:

    I'm trying to find some information in a very long debug output. I search the scrollback using the keyword, say, "usb", because I only know the needed information should appear somewhere between two lines containing "usb". And it turns out the distance between that two "usb" lines is 3 pages/screens. That means I need to scroll between those 3 pages line by line and look for the needed information .

    With current behavior, that is an easy task. After searching for "usb", I just use mouse to click the terminal area, and press "Shift+Up/Down" for scrolling line by line. I don't need to worry about scrolling beyond the other "usb" line ,because "usb"s are still highlighted and they serve as nice markers .

    With the proposed new behavior, I am lost because those nice markers are gone the moment I click the terminal area. I have no idea whether I have scrolled too much, unless I check whether I have reached the other "usb" line by reading each line word by word. That is clearly less efficient.

    Yes, I can use scrollbar to avoid the highlight disappearing, but I am dealing with a very long debug output and I need to scroll line by line between 3 pages. Scrollbar just scrolls too much and thus useless in this case.


- Jekyll Wu


On Oct. 4, 2012, 10:55 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106720/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 10:55 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> After a search, when an user click left button on the konsole view,
> remaining filters (highlight/*) are removed.
> 
> This patch will make possible continue "normal work" (without active search filters) and search, without
> having to open and close, every time, the search bar. (compliant with kate/kwrite/kdevelop....)
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h b41cc8e 
>   src/SessionController.cpp 9ee8899 
>   src/TerminalDisplay.h 8e246b8 
>   src/TerminalDisplay.cpp 871dc9f 
> 
> Diff: http://git.reviewboard.kde.org/r/106720/diff/
> 
> 
> Testing
> -------
> 
> I'm using this path from long time ago.
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121006/599d270f/attachment.html>