[Konsole-devel] Review Request: Add process info gathering support on OpenBSD
Vadim Zhukov
persgray at gmail.com
Thu Oct 4 10:50:06 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 10:50 a.m.)
Review request for Konsole and Jekyll Wu.
Changes
-------
Fix small nit (extra allocated stuff on stack).
Description
-------
ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support.
The first idea was to extend already existing FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. After some input I've created separate OpenBSDProcessInfo class based on FreeBSDProcessInfo code.
I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() and such; added kWarning() printouts if they fail) in new code. If needed I can do them as a separate diff.
Diffs (updated)
-----
src/ProcessInfo.cpp 32c86b1
Diff: http://git.reviewboard.kde.org/r/106129/diff/
Testing
-------
On OpenBSD-CURRENT.
Thanks,
Vadim Zhukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121004/32f01d5a/attachment.html>
More information about the konsole-devel
mailing list