[Konsole-devel] Review Request: Add process info gathering support on OpenBSD

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/#review19818
-----------------------------------------------------------


Sorry for the so late response. I have been blocked by setting up an OpenBSD environment for testing this patch. The funny thing is in the same time I have managed to set up the testing environment for NetBSD and DragonFly without much trouble :)

Back to this patch. Since I (and probably Kurt also) can't test it now, the safe way is to prepare a patch which does not contain any modification to existing code/class.  So please use a separate class for OpenBSD. Also, leave alone that fix for allocating kinfo_proc in the wrong unit in class FreeBSDProcessInfo. I will try to fix it in a separate commit.

Beside that, there are some minor coding style issues. 



src/ProcessInfo.cpp
<http://git.reviewboard.kde.org/r/106129/#comment15752>

    konsole code generally uses the form of 
    
       void* ptr = ...;
    
    Also, it is preferred to have only one declaration per line.
    
    There are similar issues in the following code.



src/ProcessInfo.cpp
<http://git.reviewboard.kde.org/r/106129/#comment15753>

    konsole code generally uses the kdelibs style: 
    
    for (....) {
    
    }



src/ProcessInfo.cpp
<http://git.reviewboard.kde.org/r/106129/#comment15755>

    This part feels so "C", which makes it out of place among other "C++" code. Also applies to the readProcArgs method above.
    
    But that is just my taste. If you feel uncertain about making it more "C++" like, just ignore this issue.
    
    


- Jekyll Wu


On Aug. 23, 2012, 7:29 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106129/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 7:29 p.m.)
> 
> 
> Review request for Konsole and Jekyll Wu.
> 
> 
> Description
> -------
> 
> ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support.
> The main idea is to extend already existing FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. If that's not desirable, I could create separate OpenBSDProcessInfo class.
> 
> I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() and such; added kWarning() printouts if they fail). If needed I can do them as a separate diff.
> 
> 
> Diffs
> -----
> 
>   src/ProcessInfo.cpp 32c86b1 
> 
> Diff: http://git.reviewboard.kde.org/r/106129/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121003/4379465e/attachment.html>