[Konsole-devel] Review Request: Don't call updateWebSearchMenu from selectionChanged

Dawit Alemayehu adawit at kde.org
Thu Nov 29 12:33:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107511/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

Don't call updateWebSearchMenu from selectionChanged since updateWebSearchMenu is called right before the context menu is shown. Filtering URIs becomes a very expensive operation if it is done while the user it selecting text (read: many times in a row) and causes issues like those mentioned in the aforementioned bug report.


This addresses bug 307973.
    http://bugs.kde.org/show_bug.cgi?id=307973


Diffs
-----

  src/SessionController.cpp 036bd37 

Diff: http://git.reviewboard.kde.org/r/107511/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121129/1e19f38f/attachment.html>


More information about the konsole-devel mailing list