[Konsole-devel] Review Request: making the keymapping description in the keyboard setting page not editable

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107289/#review21957
-----------------------------------------------------------


This review has been submitted with commit a990256a2fc286e4db9fbe38d403cbe79388fe64 by Jekyll Wu to branch KDE/4.9.

- Commit Hook


On Nov. 10, 2012, 11:49 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107289/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 11:49 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The description in the list of keymapping in the keyboard tab of the setting window is editable but is a no-op. Since it is possible to edit the name in the Edit pop-up window, it should be ok to just disable editing here.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp 8e44df6 
> 
> Diff: http://git.reviewboard.kde.org/r/107289/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed.
> The item description in the list is not editable but the popup edit window is still working and the list is updated properly when the description is changed in the Edit popup.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121114/ea1f1d94/attachment.html>