[Konsole-devel] Review Request: Add the possibility of "run scripts in konsole" when using dolphin

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107086/
-----------------------------------------------------------

(Updated Nov. 11, 2012, 7:56 a.m.)


Review request for Dolphin, Konsole and David Faure.


Changes
-------

use application/x-executable instead of application/x-shellscript
remove "Verion=1.0" line
remove "Terminal=false" line


Description (updated)
-------

@David, I'd like to know your idea of this workaround, because I think its usefulness will influence or be influenced by how bug 275405 will be finally resolved. 


The current situation of clicking an executable shell script in dolphin/konqueror:

1. It is always executed, instead of being opened by the preferred application according to its mimetype. (bug 275405)

2. It is executed in a silent way, without invoking konsole to provide a running environment (bug 225563). That means at least two issues:

    a). There is no feedback and no easy way for user to know whether that script has been started. He/She need use ps or ksysguard to verify it.

    b). interactive script just doesn't work.


This patch *doesn't* really solve any of the above two problems. It just provides the possibility for users to run an executable script in konsole when using dolphin/konqueror.

It adds two .desktop files: 

    applications/kde4/run-in-konsole.desktop, which can be used in the "Open with" submenu
    ServiceMenus/konsolerun.deksotp, which can be used in the "Actions" submenu

I'm not sure which solution is better, so I just provide both :)


This addresses bugs 225563 and 275405.
    http://bugs.kde.org/show_bug.cgi?id=225563
    http://bugs.kde.org/show_bug.cgi?id=275405


Diffs (updated)
-----

  desktop/CMakeLists.txt 0fe39d2 
  desktop/konsolerun.desktop PRE-CREATION 
  desktop/run-in-konsole.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107086/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121111/31bf8890/attachment.html>