[Konsole-devel] Review Request: read .keytab file in local encoding

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107286/
-----------------------------------------------------------

(Updated Nov. 11, 2012, 5:52 a.m.)


Review request for Konsole.


Changes
-------

also read other parts of the keytab file in local encoding. (not only the description). Correct version...................


Description
-------

When the keytab file contain non-ascii charactors (usually in its name for a user level keytab file when konsole has the translation for it.), it is read in the wrong encoding (although it is write back with the correct encoding) and will not appear correctly on the setup window.
This patch change it to read in the local encoding, which should be better than the old one.


Diffs (updated)
-----

  src/KeyboardTranslator.cpp 123d2c1 

Diff: http://git.reviewboard.kde.org/r/107286/diff/


Testing
-------

Compiled. Installed.
Read and write keytab files that contain translated string in its name and the encoding is always correct.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121111/23118764/attachment.html>