[Konsole-devel] Review Request: add option to disable ctrl+<mouse wheel> zooming.

[Jekyll Wu]

> On Nov. 11, 2012, 5:20 a.m., Jekyll Wu wrote:
> > Good catch! 
> > 
> > Some trivial things to do/know before pushing it :
> > 
> > 1. the tokenize function is also called in another place (just a few lines below the line this patch modifies). For consistency, also change that line .
> > 
> > 2. (optional). Open a bug on bugs.kde.org, describe the problem with a simple test case, like:
> > 
> >     cp /usr/share/apps/konsole/default.keytab ~/.kde4/share/apps/konsole/test.keytab
> > 
> >     edit test.keytab and change the line "keyboard ...." into "keyboard  ????"
> > 
> >     restart konsole and a new keyboard layout is displayed with corrupted name "?????" (screenshot)
> > 
> > 
> > Then use commit hooks "BUG:<number>" and "FIXED-IN: 4.9.4" in your commit message to close that bug. That way we can easily track what is broken and has been and fixed in each version.
> > 
> > 
> > 3. The konsole git repository follows the "first fix in master, then cherry-pick into stable if appropriate" model. So please first fix it in the master, then cherry-pick the commit into KDE/4.9 .
> > 
> > 
> >
> 
> Yichao Yu wrote:
>     Errrrr, thx, but maybe what you mean is this[1] one?
>     
>     [1] https://git.reviewboard.kde.org/r/107286/
>     
>     I will update that one.
>

Yes, I sent the comment to the wrong review :( Ignore above comment from me. 


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107281/#review21793
-----------------------------------------------------------


On Nov. 10, 2012, 8:02 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107281/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 8:02 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal is annoy sometimes and cannot be disabled. This patch adds an option to disable this behavior. (Default to the original behavior).
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h c85bd11 
>   src/EditProfileDialog.cpp 8e44df6 
>   src/EditProfileDialog.ui 45eafcc 
>   src/Profile.h f14d3a2 
>   src/Profile.cpp e81433f 
>   src/TerminalDisplay.h 8e246b8 
>   src/TerminalDisplay.cpp 871dc9f 
>   src/ViewManager.cpp faa1395 
> 
> Diff: http://git.reviewboard.kde.org/r/107281/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed.
> Default is not affected.
> After disabled the option, Ctrl+<Mouse Wheel> will not cause terminal zooming and the zooming is back after re-enabled it.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121111/bf6a08ec/attachment.html>