[Konsole-devel] Review Request: read .keytab file in local encoding

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107286/#review21795
-----------------------------------------------------------

Ship it!


Good catch! 

Some trivial things to do/know before pushing it :

1. the tokenize function is also called in another place (just a few lines below the line this patch modifies). For consistency, also change that line .

2. (optional). Open a bug on bugs.kde.org, describe the problem with a simple test case, like:

    cp /usr/share/apps/konsole/default.keytab ~/.kde4/share/apps/konsole/test.keytab

    edit test.keytab and change the line "keyboard ...." into "keyboard  ????"

    restart konsole and a new keyboard layout is displayed with corrupted name "?????" (screenshot)


Then use commit hooks "BUG:<number>" and "FIXED-IN: 4.9.4" in your commit message to close that bug. That way we can easily track what is broken and has been and fixed in each version.


3. The konsole git repository follows the "first fix in master, then cherry-pick into stable if appropriate" model. So please first fix it in the master, then cherry-pick the commit into KDE/4.9 .


- Jekyll Wu


On Nov. 10, 2012, 10:53 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107286/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 10:53 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When the keytab file contain non-ascii charactors (usually in its name for a user level keytab file when konsole has the translation for it.), it is read in the wrong encoding (although it is write back with the correct encoding) and will not appear correctly on the setup window.
> This patch change it to read in the local encoding, which should be better than the old one.
> 
> 
> Diffs
> -----
> 
>   src/KeyboardTranslator.cpp 123d2c1 
> 
> Diff: http://git.reviewboard.kde.org/r/107286/diff/
> 
> 
> Testing
> -------
> 
> Compiled. Installed.
> Read and write keytab files that contain translated string in its name and the encoding is always correct.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121111/f3cd23ba/attachment.html>