[Konsole-devel] Review Request: Do not always move the cursor to the end when editing keybinding description

Yichao Yu yyc1992 at gmail.com
Sat Nov 10 23:27:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107287/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

When editing the keybinding description in the keybinding editor, it always move the cursor to the end of line every time a key is pressed, which is caused by calling `setText` when handling the `textChanged` signal.
This patch add a new private slot to update translator's description without refreshing the KLineEdit, therefore not moving the cursor.


Diffs
-----

  src/KeyBindingEditor.h f66bb43 
  src/KeyBindingEditor.cpp ec2b0c3 

Diff: http://git.reviewboard.kde.org/r/107287/diff/


Testing
-------

Compiled and installed.

Edit the description in the keybinding editor, the description elsewhere (main setup window and keytab file on disk) is updated correctly and the cursor remain where it should be.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121110/a8fed7e3/attachment.html>


More information about the konsole-devel mailing list