[Konsole-devel] Review Request: Get back the "Manage Profiles..." entry in the context menu of konsolepart

[Eike Hein]

> On March 29, 2012, 2:31 p.m., Eike Hein wrote:
> > Hard to say. On the one hand, I think it's bad design to put it in that context menu, because managing profiles is not part of the context of an individual terminal. And as you say, it doesn't matter to Yakuake since it has a global action (in fact, it was me who asked Robert to make the slot available for that purpose, years ago). OTOH, it's true that it would probably help other KPart-using apps unaware of the slot.
> > 
> > I guess I won't really object if you add it, but it's definitely a hack.

Sorr guys, I had replied to this immediately when it came in but forgot to click "Publish" in the ReviewBoard UI, hence the huge delay ... sigh.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104361/#review11761
-----------------------------------------------------------


On March 22, 2012, 7:23 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104361/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 7:23 a.m.)
> 
> 
> Review request for Konsole, Yakuake and Eike Hein.
> 
> 
> Description
> -------
> 
> That entry was there in the early versions of KDE 4.x(like 4.1), but was gone since KDE 4.7 or even earlier. 
> 
> The rationale for getting it back :
> 
>     * "Switch Profile" only lists profiles set as "Favorite" or "Show in menu"
> 
>     * each konsolepart has its own sets of favorites, instead of reusing the sets from stand-alone Konsole
> 
>     * The only way to change favorite status is using the "Manage Profiles" dialog
> 
>     * konsolepart provide a slot "showManageProfilesDialog(QWidget* parent)" for show that dialog, but most hosting applications do not take advantage of it and provide an GUI item. Yakuake, Konversation and QuadKonsole4 seem to be the exceptions.
> 
>     * so there is no way for user to change favorite status, and "Switch Profile" always contains one item: "Default Profile". Apparently, it is confusing.
> 
> 
> Personally I don't want to add it into the context menu, because it is really a global instead of  context related action. But currently konsolepart only has a context menu, so put it there for now.
> 
> If the consensus is NOT getting it back, then it is better to remove those related code.
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc 2eacc48 
>   src/Part.h 31fff53 
>   src/Part.cpp 7bce172 
> 
> Diff: http://git.reviewboard.kde.org/r/104361/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/104361/s/485/
> after
>   http://git.reviewboard.kde.org/r/104361/s/486/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120329/30c328b5/attachment.html>