[Konsole-devel] Review Request: Get back the "Manage Profiles..." entry in the context menu of konsolepart

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104361/#review11949
-----------------------------------------------------------

Ship it!


I would tend to say to put it in the menu for basically the reasons you give.    Even better if we could allow the app calling konsolepart to selectively show/hide that menu option but I'm not sure that's even possible.
I notice that adding profiles in konsole or yakuake doesn't cause the new profiles to show up in yakuake/konsole without a restart of that app.

- Kurt Hindenburg


On March 22, 2012, 7:23 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104361/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 7:23 a.m.)
> 
> 
> Review request for Konsole, Yakuake and Eike Hein.
> 
> 
> Description
> -------
> 
> That entry was there in the early versions of KDE 4.x(like 4.1), but was gone since KDE 4.7 or even earlier. 
> 
> The rationale for getting it back :
> 
>     * "Switch Profile" only lists profiles set as "Favorite" or "Show in menu"
> 
>     * each konsolepart has its own sets of favorites, instead of reusing the sets from stand-alone Konsole
> 
>     * The only way to change favorite status is using the "Manage Profiles" dialog
> 
>     * konsolepart provide a slot "showManageProfilesDialog(QWidget* parent)" for show that dialog, but most hosting applications do not take advantage of it and provide an GUI item. Yakuake, Konversation and QuadKonsole4 seem to be the exceptions.
> 
>     * so there is no way for user to change favorite status, and "Switch Profile" always contains one item: "Default Profile". Apparently, it is confusing.
> 
> 
> Personally I don't want to add it into the context menu, because it is really a global instead of  context related action. But currently konsolepart only has a context menu, so put it there for now.
> 
> If the consensus is NOT getting it back, then it is better to remove those related code.
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc 2eacc48 
>   src/Part.h 31fff53 
>   src/Part.cpp 7bce172 
> 
> Diff: http://git.reviewboard.kde.org/r/104361/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/104361/s/485/
> after
>   http://git.reviewboard.kde.org/r/104361/s/486/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120328/4ef166f0/attachment.html>