[Konsole-devel] Review Request: Add slot into konolepart for getting current working directory

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104362/#review11790
-----------------------------------------------------------


This review has been submitted with commit a7f71fe903df30b9aaa27f02df35d0eef92fb597 by Jekyll Wu to branch master.

- Commit Hook


On March 22, 2012, 8:10 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104362/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 8:10 a.m.)
> 
> 
> Review request for Konsole, Yakuake and Eike Hein.
> 
> 
> Description
> -------
> 
> The patch is trivial, because all prerequistes are already there.
> 
> This newly added slot can hardly be seen as an API, becuase it is not friendly for hosting applications. You have to use QMetaObject::invokeMethod() to call it and get the value. 
> 
> The better choice is to update TerminalInterfaceV2(kdelibs//interfaces/terminal/kde_terminal_interface_v2.h). However, that seems like a new feature and adding new feature to kdelibs seems hard or forbidden at the moment. I have always wondered the relationship between konsolepart and TerminalInterface.
> 
> Whatever, this simple patch/hack should work. It is better than nothing.
> 
> 
> This addresses bug 214547.
>     http://bugs.kde.org/show_bug.cgi?id=214547
> 
> 
> Diffs
> -----
> 
>   src/Part.h 31fff53 
>   src/Part.cpp 7bce172 
> 
> Diff: http://git.reviewboard.kde.org/r/104362/diff/
> 
> 
> Testing
> -------
> 
> Using yakuake as the hosting application to test the new slot. Seems fine.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120323/d6d07d2c/attachment.html>