[Konsole-devel] Review Request: konsolepart should emit a signal when the current directory of active session changes

Jekyll Wu adaptee at gmail.com
Fri Mar 23 04:57:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104372/
-----------------------------------------------------------

Review request for Konsole and Eike Hein.


Description
-------

This simple patch adds and emits one signal : currentDirChanged(const QString& dir).


It should work. Maybe the signal should be renamed to currentDirectoryChanged ?


This addresses bug 156919.
    http://bugs.kde.org/show_bug.cgi?id=156919


Diffs
-----

  src/SessionController.h 3c749b0 
  src/SessionController.cpp 0ee550d 
  src/Part.h 31fff53 
  src/Part.cpp 6767466 
  src/Session.h abf9529 
  src/Session.cpp 4ecd2d7 

Diff: http://git.reviewboard.kde.org/r/104372/diff/


Testing
-------

Use yakuake to connect and test that signal. Seems fine.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120323/d12a6db4/attachment.html>


More information about the konsole-devel mailing list