[Konsole-devel] Review Request: Add slot into konolepart for getting current working directory

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104362/
-----------------------------------------------------------

Review request for Konsole, Yakuake and Eike Hein.


Description
-------

The patch is trivial, because all prerequistes are already there.

This newly added slot can hardly be seen as an API, becuase it is not friendly for hosting applications. You have to use QMetaObject::invokeMethod() to call it and get the value. 

The better choice is to update TerminalInterfaceV2(kdelibs//interfaces/terminal/kde_terminal_interface_v2.h). However, that seems like a new feature and adding new feature to kdelibs seems hard or forbidden at the moment. I have always wondered the relationship between konsolepart and TerminalInterface.

Whatever, this simple patch/hack should work. It is better than nothing.


This addresses bug 214547.
    http://bugs.kde.org/show_bug.cgi?id=214547


Diffs
-----

  src/Part.h 31fff53 
  src/Part.cpp 7bce172 

Diff: http://git.reviewboard.kde.org/r/104362/diff/


Testing
-------

Using yakuake as the hosting application to test the new slot. Seems fine.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120322/9cdccc2f/attachment.html>