[Konsole-devel] Review Request: Add script for migrating tabbar and menubar options from default profile

Jekyll Wu adaptee at gmail.com
Wed Mar 14 12:45:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104253/
-----------------------------------------------------------

(Updated March 14, 2012, 12:45 p.m.)


Review request for Konsole.


Changes
-------

Return early if 

  * The user has not specifed his own default profile
  * The specified default profile does not exist


Description
-------

The bug report has described the problem quite clear.

The script is quite stupid, and I hope it is stupid enough to be easily reviewed.

A possile issure is where to organize the kconf-update related stuff in the repository. I put it under data/updaters/. Not sure whether that is a good place.


This addresses bug 293231.
    http://bugs.kde.org/show_bug.cgi?id=293231


Diffs (updated)
-----

  data/CMakeLists.txt 2b8dd95 
  data/updaters/CMakeLists.txt PRE-CREATION 
  data/updaters/konsole-2.9.0-global-options.sh PRE-CREATION 
  data/updaters/konsole.upd PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104253/diff/


Testing
-------

It works with the exsiting KDE/4.8 branch


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120314/e462aedd/attachment.html>


More information about the konsole-devel mailing list