[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Adam Batkin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/
-----------------------------------------------------------

(Updated March 6, 2012, 12:48 a.m.)


Review request for Konsole.


Changes
-------

Rebased changes to master. Still has the separate Mouse in the Profile settings, but I can get rid of that if folks think that would be better.


Description
-------

* Creates new "Mouse" Profile Options tab with all of the mouse stuff
* Selected text can now go to X Selection AND Clipboard (instead of ONLY X Selection)
* Middle-Mouse clicks can paste from X Selection or Profile

The whole rationale here is that I almost never care about the X Selection (and
I'm probably not alone). And in the few cases where I DO care, well, that's my
problem. So this patch leaves all of the defaults as-is (no one will notice a
change) but for people for whom it makes a difference, now they can control
what is going on.


This addresses bug 183490.
    http://bugs.kde.org/show_bug.cgi?id=183490


Diffs (updated)
-----

  src/EditProfileDialog.h c669b7f 
  src/EditProfileDialog.cpp cbb4875 
  src/EditProfileDialog.ui 9208009 
  src/Profile.h 698019b 
  src/Profile.cpp 5e0a0e2 
  src/SessionController.h 46714c0 
  src/SessionController.cpp e937753 
  src/TerminalDisplay.cpp c26d5a9 

Diff: http://git.reviewboard.kde.org/r/103861/diff/


Testing
-------


Screenshots
-----------

konsole "Mouse" profile configuration tab
  http://git.reviewboard.kde.org/r/103861/s/436/


Thanks,

Adam Batkin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120306/38e5f31f/attachment.html>