[Konsole-devel] Review Request: konsolepart should not provide meaningless action to its host

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104034/#review11043
-----------------------------------------------------------


This review has been submitted with commit 08de49da1cf4c89c375d7eea267bce3b46c05527 by Jekyll Wu to branch master.

- Commit Hook


On Feb. 20, 2012, 7:55 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104034/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 7:55 p.m.)
> 
> 
> Review request for Konsole and Eike Hein.
> 
> 
> Description
> -------
> 
> What the patch does is simple: for class SessionController, provide less actions for konsolepart and more actions for stand-alone konsole.
> 
> This is not a good solution for the reported problem, but I think it at least makes the situation better.
> 
> Below is simple explanations for not providing those  actions:
> 
> copy-input-to-all-tabs
> copy-input-to-selected-tabs
> copy-input-to-none
>  
>    Since konsolepart currently does not provide tabbar and tabs, those actions are meaningless for konsolepart.
> 
> rename-session
> 
>    Since konsolepart does not support tabbar, this action is not that useful. Yakuake has its own action for renaming.
> 
> zmodem-upload
> 
>    Not quite sure about this. I just guess this feature is not widely used.
> 
> monitor-activity
> monitor-silence
> 
>    Not quite sure, either. My general tendency is remove most actions not included in the context menu at this moment.
> 
> set-encoding
> 
>    No entry within context menu(Although I'm confuse why), no default shortcut; why provide this action in konsolepart?
> 
> enlarge-font
> shrink-font
> 
>    Three unconfigurable shortcuts are involved. Better not provide them until the actions provided by konsolepart are configurable and konsolepart loads customized shortcuts.
> 
> 
> The 3 actions related with "Find"
> 
>    Before konsolepart supports searching, those actions are meaningless for konsolepart.
> 
> 
>    
> 
> 
> This addresses bug 248469.
>     http://bugs.kde.org/show_bug.cgi?id=248469
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 2382023 
>   src/SessionController.cpp d09a0fd 
> 
> Diff: http://git.reviewboard.kde.org/r/104034/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120301/63943f57/attachment.html>