[Konsole-devel] Review Request: Open links from konsole with single mouse click

[Asko Eronen]

> On June 21, 2012, 2:24 p.m., Jekyll Wu wrote:
> > Thanks for the patch. I haven't read the code closely, but it looks and works fine for me so far .
> > 
> > There is one design thing I find a little problematic and would like to discuss here.
> > 
> > It is the relationship between the existing "underline links" option the new "open links by left click". They are independent in the current patch, so there are 4 possible combination. One of them is "underline links" is off and "open links by left click" on, and the result is there is no visual indication(which is good) when hovering but clicking will open the link. That is not good, because it might not only confuse users(from where is this link opened?) but also scare users(is my system controlled by others). 
> > 
> > So I think the better design is the new option should be configurable and effective only when "underline links" is enabled. When it comes to UI, I would suggest changing :
> > 
> >     [ ] underline links                   [ ]  open links through left click(or something like that)
> > 
> > to 
> > 
> >     [ ] underline links
> >         [ ] open links through left click(or something like that)
> > 
> > 
> >
> 
> Kurt Hindenburg wrote:
>     Yes I agree with Jekyll - force underline to be displayed for single-clicking open of links.
>     
>     A minor point - how about using toggleOpenLinksBySingleClick
>     
>     I don't think the system wide setting of "single click to open files/folders" applies to Konsole.

I thought about the releationship between these two settings, but couldn't deside wihch would be the best solution. Thanks for the feedback. I will fix this and submit an updated patch when it's done.

Feel free to look at the code and give me any feedback from it. This is my first touch for KDE coding or any public open source project for that matter. I'm sure there are thing that I'm not just yet aware of.


- Asko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105282/#review14952
-----------------------------------------------------------


On June 17, 2012, 7:22 p.m., Asko Eronen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105282/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 7:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Added optional feature in konsole, which allows opening links with single mouse click.
> 
> By default, the option is disabled. It can be enabled from profile manager -> Mouse -> "Mouse Click opens links"
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 2345925e3998f92c1d1fcaae85c36c30782c319f 
>   src/EditProfileDialog.cpp f5cfa8c4a715683f31da93183d69979e7cec8818 
>   src/EditProfileDialog.ui 8b8e83cd5a31ea2a4fd7dbdfcfa1db0b9af5adba 
>   src/Profile.h 83616c4fe62dd1c3bc70d12b62ed0d876d5f0fce 
>   src/Profile.cpp 67cd80ea84af47c446071cbcc05af6af4d049733 
>   src/TerminalDisplay.h c6e5972d5bfa9dd21bc0d880a56a76efece578f7 
>   src/TerminalDisplay.cpp 849ce0d0598a2d6a1085bd8776882dcfd66d21ea 
>   src/ViewManager.cpp 40ed9150cec61dc8677839d3c5e47ea7b22b65fd 
> 
> Diff: http://git.reviewboard.kde.org/r/105282/diff/
> 
> 
> Testing
> -------
> 
> Tested with simple terminal usage using gentoo package manager, irssi and htop. No problems ocured with them.
> 
> 
> Thanks,
> 
> Asko Eronen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120630/29e649c3/attachment.html>