[Konsole-devel] Review Request: split view: automatically close the split area if it becomes empty.

[Francesco Cecconi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104717/
-----------------------------------------------------------

(Updated June 29, 2012, 11:18 a.m.)


Review request for Konsole.


Changes
-------

Use ViewManager->widget() method for return _viewSplitter (new method is not necessary).


Description
-------

automatically close blank split, after that last tab is moved.


This addresses bug 275771.
    http://bugs.kde.org/show_bug.cgi?id=275771


Diffs (updated)
-----

  src/ViewContainer.h d5bdf73 
  src/ViewContainer.cpp 980c130 
  src/ViewContainerTabBar.h 5b97abc 
  src/ViewContainerTabBar.cpp 29805f3 
  src/ViewManager.h 7d1079e 
  src/ViewManager.cpp 40ed915 

Diff: http://git.reviewboard.kde.org/r/104717/diff/


Testing
-------

- one tab + split + one tab -> move split right/left, no blank area
- from bug: after step 4 no blank area

seems to work well but more test are necessary. ;)


Thanks,

Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120629/b086d3be/attachment.html>