[Konsole-devel] Review Request: clear command line before using bookmark

Jekyll Wu adaptee at gmail.com
Mon Jun 25 05:18:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105298/#review15091
-----------------------------------------------------------

Ship it!


I think this is OK to go. Could you also add "tcsh" (not tclsh) into that shell list? I think the patch works well with it, too

Side note: the ability of clearing current cmdline is also needed by some konsolepart host applications(like the terminal panel in dolphin). So in the long term I think it is a good idea to provide a clear interface for clearing the current cmdline.



- Jekyll Wu


On June 24, 2012, 6:45 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105298/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 6:45 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Clear the command line if no active process or in a ssh session.  Ctrl+E and Ctrl+U
> 
> 
> This addresses bug 46233.
>     http://bugs.kde.org/show_bug.cgi?id=46233
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 5bfecea 
>   src/SessionController.cpp 2308a03 
> 
> Diff: http://git.reviewboard.kde.org/r/105298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120625/a643311c/attachment.html>


More information about the konsole-devel mailing list