[Konsole-devel] Review Request: protect control characters from deletion

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105325/#review15055
-----------------------------------------------------------


Thanks for your research and patches. However, the patches fail to apply cleanly against the master code. Please recreate the patches against master code at https://projects.kde.org/projects/kde/kde-baseapps/konsole

Another minor thing: please fill the "Bugs" field of this review request with the relavant bug number(278991).



- Jekyll Wu


On June 22, 2012, 10:15 a.m., Alexander Sulfrian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105325/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 10:15 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This review contains three patches. I do not know how to submit them as separate
> patches for one review. I attached the single patches as files to the review.
> 
> - protect control characters from deletion
> 
>   If you remove characters from a line (replace with space) and first
>   character, that should be removed, is the first character with a new
>   color, do not remove the color but replace the character.
> 
> - save color on change
> 
>   If the colors change, you need to save it in the next character to be
>   able to complete the line with the correct colors.
> 
> - keep color for additional character at line end
> 
>   If the current line contains less characters than the width of the
>   current window, default chars were used to draw the additional
>   characters. This results in transparent (missing) line endings in some
>   ncurses applications, that draw lines using the background of space
>   characters. This keeps the color of the last character to draw the
>   missing chars.
> 
> 
> Diffs
> -----
> 
>   src/Character.h d7afa148e2c64c75af035a3d073ea8f4d2bd9130 
>   src/Screen.cpp 3d8944c5b22b553765256f53e33cae42cd518bba 
> 
> Diff: http://git.reviewboard.kde.org/r/105325/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Sulfrian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120624/c1d46b11/attachment.html>