[Konsole-devel] Review Request: Open links from konsole with single mouse click

[Lindsay Roberts]

> On June 21, 2012, 10:19 p.m., Mark Gaiser wrote:
> > Hi,
> > 
> > First of all, thank you for your patch and the time you've put into it.
> > Then to drop a little bomb. I strongly suggest _not_ committing this. KDE has a click policy for single or double click. It's hidden in the system settings somewhere. I think it's a better idea to let that policy work with Konsole rather then making a Konsole only option for single/double click.
> > 
> > Sorry for the little bomb.
> > 
> > Cheers,
> > Mark

I think you're conflating that option. Currently you can't single click or double click links to open them in Konsole. Further, the single/double click is explicitly for "files and folders". Possibly there are already situations where it has influence outside its purview, but this is no reason to stretch it further.


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105282/#review14971
-----------------------------------------------------------


On June 17, 2012, 7:22 p.m., Asko Eronen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105282/
> -----------------------------------------------------------
> 
> (Updated June 17, 2012, 7:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Added optional feature in konsole, which allows opening links with single mouse click.
> 
> By default, the option is disabled. It can be enabled from profile manager -> Mouse -> "Mouse Click opens links"
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 2345925e3998f92c1d1fcaae85c36c30782c319f 
>   src/EditProfileDialog.cpp f5cfa8c4a715683f31da93183d69979e7cec8818 
>   src/EditProfileDialog.ui 8b8e83cd5a31ea2a4fd7dbdfcfa1db0b9af5adba 
>   src/Profile.h 83616c4fe62dd1c3bc70d12b62ed0d876d5f0fce 
>   src/Profile.cpp 67cd80ea84af47c446071cbcc05af6af4d049733 
>   src/TerminalDisplay.h c6e5972d5bfa9dd21bc0d880a56a76efece578f7 
>   src/TerminalDisplay.cpp 849ce0d0598a2d6a1085bd8776882dcfd66d21ea 
>   src/ViewManager.cpp 40ed9150cec61dc8677839d3c5e47ea7b22b65fd 
> 
> Diff: http://git.reviewboard.kde.org/r/105282/diff/
> 
> 
> Testing
> -------
> 
> Tested with simple terminal usage using gentoo package manager, irssi and htop. No problems ocured with them.
> 
> 
> Thanks,
> 
> Asko Eronen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120622/36ffe369/attachment.html>