[Konsole-devel] Review Request: clear command line before using bookmark

[Kurt Hindenburg]

> On June 21, 2012, 9:03 a.m., Jekyll Wu wrote:
> > src/SessionController.cpp, line 277
> > <http://git.reviewboard.kde.org/r/105298/diff/1/?file=69812#file69812line277>
> >
> >     I don't think sending "Ctrl+E" and "Ctrl+U" is the best way of clearing the current line of shell.  That sounds quite bashism and emacsim. What if the user is not using bash, especailly not using the default Emacs style key binding (say, use customized vi style binding in zsh)?  
> >     
> >     I think sending "Ctrl+C"(0x03) is the better way.
> >     
> >

If I recall from previous testing, some shells can't handle Ctrl+C - I'll have to test it.  Also I think the ssh part will have to be removed: ssh server; vi testfile - click bookmark entry


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105298/#review14939
-----------------------------------------------------------


On June 19, 2012, 2:30 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105298/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 2:30 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Clear the command line if no active process or in a ssh session.  Ctrl+E and Ctrl+U
> 
> 
> This addresses bug 46233.
>     http://bugs.kde.org/show_bug.cgi?id=46233
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 2308a03 
> 
> Diff: http://git.reviewboard.kde.org/r/105298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120621/6f8094fd/attachment.html>