[Konsole-devel] Review Request: Fix assert on new search matches in background tabs

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105244/#review14722
-----------------------------------------------------------

Ship it!


Ship It!

- Jekyll Wu


On June 13, 2012, 7:22 p.m., Lindsay Roberts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105244/
> -----------------------------------------------------------
> 
> (Updated June 13, 2012, 7:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> As mentioned in the linked bug report, konsole was asserting on background tab updates with search enabled. This was caused by an assumption that a tab would always have the search bar when it had a search filter active, invalidated by fixing issue 168769.
> 
> This is a minimal fix to to fit with current release stage, simply not updating search matches if a search bar isn't attached to the tab ("Session") instead of asserting.
> 
> Bug was introduced by fix for issue https://bugs.kde.org/show_bug.cgi?id=168769 .
> 
> 
> This addresses bug 301682.
>     http://bugs.kde.org/show_bug.cgi?id=301682
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 77907ec 
> 
> Diff: http://git.reviewboard.kde.org/r/105244/diff/
> 
> 
> Testing
> -------
> 
> Tested looping background tab updates with search enabled - bug was instantly reproducible and gone with the patch.
> 
> 
> Thanks,
> 
> Lindsay Roberts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120614/83a3e599/attachment.html>