[Konsole-devel] [Bug 301458] Konsole ask if it should close sessions on logout

[Jekyll Wu]

https://bugs.kde.org/show_bug.cgi?id=301458

Jekyll Wu <adaptee at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adaptee at gmail.com

--- Comment #1 from Jekyll Wu <adaptee at gmail.com> ---

Your observation is correct.  However, that is the side effect of another fix. 
See bug 127194 and 
https://projects.kde.org/projects/kde/kde-baseapps/konsole/repository/revisions/3309e5b12280b27a6e632f9c5e43a38f8f0791bf.

Here is the related change: 

 bool MainWindow::queryClose()
 {
-    if (kapp->sessionSaving() ||
-            _viewManager->viewProperties().count() < 2)
+    // TODO: Ideally, we should check what process is running instead
+    //       of just how many sessions are running.
+    // If only 1 session is running, don't ask user to confirm close.
+    if (_viewManager->viewProperties().count() < 2)
         return true;

@Kurt, I think we need to re-evaulate that change based upon this report and
bug 127194.  Is there some way to distinguish  between power-off and log-out ? 

I'm currently inclined to revert the change, since "logging out with konsole
open " is a common use case. The confirmation dialog is annoying during
log-out, and if users choose  "do not ask me again", they also disable the
confirmation for closing konsole window with multiple tabs.

Another "solution" might be we use two different confirmation dialogs(and thus
two different config entries within konsolerc) for the two different situation:

   1.  power-off or log-out( when kapp->sessionSaving() is true )
   2.  closing konsole window 

That makes the annoyance just one click , and users won't lose the protection
for closing konsole window accidentally.  But that might be overkill and would
introduce new option/UI/strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.