[Konsole-devel] Review Request: replace the font size slider with a numinput

[Francesco Cecconi]

> On July 30, 2012, 9:42 p.m., Francesco Cecconi wrote:
> > The slider is used to suggest a quick range of font sizes (9/22), but this is not the best way.
> > 
> > In dolphin for example, one combo with four options "Small, Medium, Large, Huge" is used for this scope.
> > 
> > The second way is better in my opinion.
> 
> Francesco Cecconi wrote:
>     remove completely the "slider" is another solution. :)
> 
> Kurt Hindenburg wrote:
>     Well I think dolphin's slider (icon size) is different from Konsole's.  Also I don't imagine that people change konsole's text size by a huge amount.  I'm always annoying w/ Konsole's slider and it often comes up w/ a fraction when it should just be integers.  And you can also use the 'select font' dialog to change the size for huge changes.

> I'm always annoying w/ Konsole's slider and it often comes up w/ a fraction when it should just be integers.

Yes, this thing is annoying.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105796/#review16692
-----------------------------------------------------------


On July 30, 2012, 2:50 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105796/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:50 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.
> 
> If we really want a slider, kintnuminput has the option to add it as well.
> 
> I also removed the "size :" from the preview label as I was looking at bko 174998.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.ui be3e672 
>   src/EditProfileDialog.h 4715ec5 
>   src/EditProfileDialog.cpp 68d5729 
> 
> Diff: http://git.reviewboard.kde.org/r/105796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120731/df39b38d/attachment.html>