[Konsole-devel] Review Request: replace the font size slider with a numinput

Kurt Hindenburg kurt.hindenburg at gmail.com
Mon Jul 30 14:50:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105796/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.

If we really want a slider, kintnuminput has the option to add it as well.

I also removed the "size :" from the preview label as I was looking at bko 174998.


Diffs
-----

  src/EditProfileDialog.ui be3e672 
  src/EditProfileDialog.h 4715ec5 
  src/EditProfileDialog.cpp 68d5729 

Diff: http://git.reviewboard.kde.org/r/105796/diff/


Testing
-------


Thanks,

Kurt Hindenburg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120730/7ab9d504/attachment.html>


More information about the konsole-devel mailing list