[Konsole-devel] Review Request: make find shortcut event consistent with other KDE apps.

[Francesco Cecconi]

> On July 27, 2012, 5:23 p.m., Jekyll Wu wrote:
> > src/SessionController.cpp, line 594
> > <http://git.reviewboard.kde.org/r/105723/diff/2/?file=74936#file74936line594>
> >
> >     Please revert the change related with the shortcut. 
> >     
> >     The existing code is written by intention to make sure the "Find" action have default shortcut in stand-alone konsole but not in konsolepart.  That decision might be problematic, but it is better to make the change in a different commit/review. 
> >

reverted, many thanks for your time Jekyll. :)


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105723/#review16537
-----------------------------------------------------------


On July 27, 2012, 6:53 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105723/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 6:53 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When search bar is visible, pressing the shortcut (ctrl+alt+f) again set focus to the search box.
> 
> 
> This addresses bug 271668.
>     http://bugs.kde.org/show_bug.cgi?id=271668
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 1136248 
>   src/SessionController.cpp f90f927 
> 
> Diff: http://git.reviewboard.kde.org/r/105723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120727/2a3b48ea/attachment.html>