[Konsole-devel] Review Request: Open links from konsole with single mouse click

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105282/#review15731
-----------------------------------------------------------

Ship it!


I think it is OK to go except some small issues. 

If you already have a developer account, please fix those issues and commit it to the master branch (remember use the "REVIEW:<id>" hook in the commit message to automatically close this review ).  If not, I will do it for you.



src/EditProfileDialog.ui
<http://git.reviewboard.kde.org/r/105282/#comment12231>

    build Warning: The name 'horizontalLayout' (QHBoxLayout) is already in use, defaulting to 'horizontalLayout1'



src/TerminalDisplay.cpp
<http://git.reviewboard.kde.org/r/105282/#comment12232>

    It feels more natural and consistent with UI implication to put _underlineLinks before _openLinksBySingleClick in this check



src/TerminalDisplay.cpp
<http://git.reviewboard.kde.org/r/105282/#comment12233>

    similar order problem.


- Jekyll Wu


On July 10, 2012, 6:23 p.m., Asko Eronen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105282/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 6:23 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Added optional feature in konsole, which allows opening links with single mouse click.
> 
> By default, the option is disabled. It can be enabled from profile manager -> Mouse -> "Mouse Click opens links"
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h f9e35e6 
>   src/EditProfileDialog.cpp 678636e 
>   src/EditProfileDialog.ui e4196de 
>   src/Profile.h 10a71b6 
>   src/Profile.cpp aded720 
>   src/TerminalDisplay.h 8d91ddb 
>   src/TerminalDisplay.cpp 6a47299 
>   src/ViewManager.cpp 0d01aae 
> 
> Diff: http://git.reviewboard.kde.org/r/105282/diff/
> 
> 
> Testing
> -------
> 
> Tested with simple terminal usage using gentoo package manager, irssi and htop. No problems ocured with them.
> 
> 
> Thanks,
> 
> Asko Eronen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120712/29f38cdb/attachment.html>